Review Request 125357: make_fat32_compatible: Actually remove double quotes

Christian Ehrlicher ch.ehrlicher at gmx.de
Sat Dec 19 20:16:29 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125357/#review89753
-----------------------------------------------------------


I think it's ok after the fix.


utils/patternparser.cpp (line 359)
<https://git.reviewboard.kde.org/r/125357/#comment61496>

    " was replaced with ' here (intentional?) which is now no longer the case.


- Christian Ehrlicher


On Dez. 19, 2015, 8:11 nachm., Ian Schwarz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125357/
> -----------------------------------------------------------
> 
> (Updated Dez. 19, 2015, 8:11 nachm.)
> 
> 
> Review request for KDE Multimedia and Marco Nelles.
> 
> 
> Repository: audex
> 
> 
> Description
> -------
> 
> The encoding process fails whenever the option to produce FAT32 compatible filenames is enabled and a song title contains one or more double quotes.
> 
> 
> Diffs
> -----
> 
>   utils/patternparser.cpp 40c3acc 
> 
> Diff: https://git.reviewboard.kde.org/r/125357/diff/
> 
> 
> Testing
> -------
> 
> Compiles and fixes the problem.
> 
> 
> Thanks,
> 
> Ian Schwarz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151219/360ea953/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list