Review Request 123121: Adding a tooltip to VolumeSlider

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123121/#review84365
-----------------------------------------------------------


I would like a bit more spacing, so I added it. But apart from that the patch is fine. Two comments though for future developers:
1) The patch operates on the value of one individual channel slider, and thus is representing only the value of that channel. This is technically not 100% sound for a corner case: The average of all channels should be displayed, as given by the "underlying" Volume class. On the other hand, in "joined slider mode", the slider should already represent the average of all channels. And as soon as you move the slider, all channels are changed. So it is likely really exact enough.
2) Future directions: It would be better to do the percentage calculation via the Volume class, as it handles corner cases like muting. But due to "auto-unmuting" the value is factually also correct. As there is no pointer/reference to the "underlying" Volume object in the MDWSlider, I would say: Just keep it like this.

- Christian Esken


On April 25, 2015, 4:26 p.m., Ronnie Thomas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123121/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 4:26 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Bugs: 320949
>     http://bugs.kde.org/show_bug.cgi?id=320949
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> This patch adds a tooltip to the VolumeSlider, which shows the current value of the slider in percentage. The tooltip is shown only when the slider handle is selected, and it changes its value dynamically when the slider is moved from its current position.
> Possible implementation of bug 320949.
> 
> 
> Diffs
> -----
> 
>   gui/volumeslider.h 616c9a0 
>   gui/volumeslider.cpp 1a4166e 
> 
> Diff: https://git.reviewboard.kde.org/r/123121/diff/
> 
> 
> Testing
> -------
> 
> Tested for both horizontal and vertical orientation of the slider.
> 
> 
> Thanks,
> 
> Ronnie Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150825/ccfade5a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia