Review Request 124324: Fix build w/ optional alsa, make HAVE_LIBASOUND2 work

Christian Esken esken at kde.org
Tue Aug 25 20:41:56 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124324/#review84358
-----------------------------------------------------------

Ship it!


Thanks for the patch. Looks fine. Shuip it.

- Christian Esken


On July 29, 2015, 10:28 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124324/
> -----------------------------------------------------------
> 
> (Updated July 29, 2015, 10:28 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> Fix build w/ optional alsa, make HAVE_LIBASOUND2 work
> 
> ifdef HAVE_LIBASOUND2 was already used in backends/kmix-backends.cpp but not defined
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 128d2ac6129129aed09731a7e0300b2e61a3dbe6 
>   backends/kmix-backends.cpp 14ecfb304f8808f87273802e3b32b86ad0c26456 
> 
> Diff: https://git.reviewboard.kde.org/r/124324/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150825/a579316f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list