Review Request 124826: Remove unused dependency.
Michael Pyne
mpyne at kde.org
Tue Aug 25 17:11:06 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124826/#review84347
-----------------------------------------------------------
Ship it!
This makes sense. There is a TODO entry to check whether the global keyboard shortcuts are setup properly in its kcm module but I also didn't see anything using the KCM library itself.
Note that there is a dependency against kcmshell5, but that isn't provided by KF5::KCMUtils.
- Michael Pyne
On Aug. 19, 2015, 6:42 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124826/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 6:42 p.m.)
>
>
> Review request for KDE Multimedia.
>
>
> Repository: kmix
>
>
> Description
> -------
>
> I can't find any kcmutils usage, so remove it.
>
>
> Diffs
> -----
>
> CMakeLists.txt 01afa4ad7c54ad1969fe3b6d733096aa2abd7f33
>
> Diff: https://git.reviewboard.kde.org/r/124826/diff/
>
>
> Testing
> -------
>
> Builds, runs. Inspected source.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150825/7541aed2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list