Review Request 124827: Fix build with missing ALSA.
Michael Pyne
mpyne at kde.org
Tue Aug 25 17:04:30 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124827/#review84346
-----------------------------------------------------------
Ship it!
KMix isn't my thing but the change looks correct and appears to match the existing conditional-compilation flags for ALSA, so looks good to me.
- Michael Pyne
On Aug. 19, 2015, 7:09 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124827/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2015, 7:09 p.m.)
>
>
> Review request for KDE Multimedia.
>
>
> Repository: kmix
>
>
> Description
> -------
>
> ALSA is not marked as required, but build fails if it's missing.
>
>
> Diffs
> -----
>
> CMakeLists.txt 01afa4ad7c54ad1969fe3b6d733096aa2abd7f33
> backends/kmix-backends.cpp 14ecfb304f8808f87273802e3b32b86ad0c26456
>
> Diff: https://git.reviewboard.kde.org/r/124827/diff/
>
>
> Testing
> -------
>
> Builds, runs.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150825/30533792/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list