Review Request 124825: Remove unused dependencies.

Harald Sitter sitter at kde.org
Thu Aug 20 07:50:04 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124825/#review84078
-----------------------------------------------------------

Ship it!


Ship It!


CMakeLists.txt (line 33)
<https://git.reviewboard.kde.org/r/124825/#comment58226>

    ./src/app/mainWindow.cpp://#include <KNotificationRestrictions> // kf5 FIXME
    
    -.-
    
    Given that the entire use is not ported and commented out/disabled I am fine with ditching it from finding for now.


- Harald Sitter


On Aug. 19, 2015, 6:28 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124825/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 6:28 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> I can't find any use of these dependencies, so remove them.
> 
> 
> Diffs
> -----
> 
>   src/app/loadView.cpp 31a2ddf9034276eecfd6c91a6f0db1a7391851bd 
>   src/app/CMakeLists.txt d418f5cae0a617ba96681950942ce0eea5f766ed 
>   CMakeLists.txt 558acfaaec2698b92821c9e31153b95ff8bec43f 
> 
> Diff: https://git.reviewboard.kde.org/r/124825/diff/
> 
> 
> Testing
> -------
> 
> Builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150820/b52cecdb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list