Review Request 123121: Adding a tooltip to VolumeSlider

[Ronnie Thomas]

> On April 25, 2015, 11:51 a.m., Christian Esken wrote:
> > Thanks for your patch.
> > It looks fine. It is also less intrusive than a permanently (actually I presume that it is permanenz) shown percentage, as the patch proposal on https://bugs.kde.org/show_bug.cgi?id=320949 , so I would say we should go for it.
> 
> Ronnie Thomas wrote:
>     Hello Christian,
>     
>     I also think a tooltip would be a better option to add, instead of a permanent label of some sort. I just now noticed that the tooltip was being resized unnecessarily, when not at value 100 and added a small patch to fix it. If there are any other changes to be made, I'll be happy to do so.
> 
> Christian Esken wrote:
>     Ronnie, if you have write access to the repo, feel free to commit.
> 
> Ronnie Thomas wrote:
>     Hmm... I don't think I have, I've never worked on kmix before, can you commit on my behalf?? Or is there some way to gain commit access?

I'm currently not applying for developer access, so could you go ahead and commit the changes... Thanks Christian!


- Ronnie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123121/#review79495
-----------------------------------------------------------


On April 25, 2015, 4:26 p.m., Ronnie Thomas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123121/
> -----------------------------------------------------------
> 
> (Updated April 25, 2015, 4:26 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Bugs: 320949
>     http://bugs.kde.org/show_bug.cgi?id=320949
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> This patch adds a tooltip to the VolumeSlider, which shows the current value of the slider in percentage. The tooltip is shown only when the slider handle is selected, and it changes its value dynamically when the slider is moved from its current position.
> Possible implementation of bug 320949.
> 
> 
> Diffs
> -----
> 
>   gui/volumeslider.h 616c9a0 
>   gui/volumeslider.cpp 1a4166e 
> 
> Diff: https://git.reviewboard.kde.org/r/123121/diff/
> 
> 
> Testing
> -------
> 
> Tested for both horizontal and vertical orientation of the slider.
> 
> 
> Thanks,
> 
> Ronnie Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150426/d792b19d/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia