Review Request 122866: Volume up/down unmutes first, then does nothing else

[Jan Kundrát]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122866/
-----------------------------------------------------------

(Updated April 12, 2015, 11:08 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia and Christian Esken.


Changes
-------

Submitted with commit 2ca8f11980cdbb649b063f15bdc54042c3a94a6a by Jan Kundrát to branch master.


Repository: kmix


Description
-------

Volume up/down unmutes first, then does nothing else

In KDE4, the volume up and down keys only unmuted when the volume was
originally muted, without performing the extra volume change. I like
this behavior because it makes it very simple to restore the original
volume after a quick mute.

The former behavior where the volume was first unmuted, then brought
down to 0, and then increased a bit, caused an effective loss of the
original volume value. Not a big deal, but my muscle memory is already
trained.


Diffs
-----

  core/mixdevice.cpp 7fce6ee201bca4b523ab76552636039e09bd2f3f 

Diff: https://git.reviewboard.kde.org/r/122866/diff/


Testing
-------

Available as a git branch at kde:clones/kmix/jkt/kmix, branch volume-keys-unmute-first . Works as advertized on my shiny new Plasma 5.2.1 session.


Thanks,

Jan Kundrát

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150412/8009e399/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia