Review Request 123232: Use CMAKE_INSTALL_FULL_DATAROOTDIR

[Harald Sitter]

> On April 9, 2015, 6:40 p.m., Andreas Hartmetz wrote:
> > This commit still breaks the build for me. I just updated and recompiled. phonon-vlc didn't compile because CMAKE_INSTALL_DATAROOTDIR was undefined in phonon, which produced a broken PhononConfig.cmake with:
> > 
> > set(PHONON_BUILDSYSTEM_DIR "/share/phonon/buildsystem/")
> 
> Andreas Hartmetz wrote:
>     ...now fixed again with commit d23f0ade0168eba6ef5f6fd52b1476d48e567bfc.

Uhm, I think using the _FULL_ variable to set SHARE_INSTALL_PREFIX is going to break installations to a different prefix as the fullpath will force it to go to whatever is the standard. So it would always attempt to install to /usr/share/... even when prefix was set to $HOME. Still broken for someone.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123232/#review78719
-----------------------------------------------------------


On April 9, 2015, 4:04 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123232/
> -----------------------------------------------------------
> 
> (Updated April 9, 2015, 4:04 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> This allows installing the architecture independent data outside
> the prefix, for example on a multiarch layout where the prefix
> is /usr/{host-triplet}.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 44862b5 
> 
> Diff: https://git.reviewboard.kde.org/r/123232/diff/
> 
> 
> Testing
> -------
> 
> Built, installed it and also built phonon-vlc against it.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150410/1a64d854/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia