Review Request 123232: Use CMAKE_INSTALL_FULL_DATAROOTDIR
Andreas Hartmetz
ahartmetz at gmail.com
Thu Apr 9 19:40:02 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123232/#review78719
-----------------------------------------------------------
This commit still breaks the build for me. I just updated and recompiled. phonon-vlc didn't compile because CMAKE_INSTALL_DATAROOTDIR was undefined in phonon, which produced a broken PhononConfig.cmake with:
set(PHONON_BUILDSYSTEM_DIR "/share/phonon/buildsystem/")
- Andreas Hartmetz
On April 9, 2015, 4:04 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123232/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 4:04 p.m.)
>
>
> Review request for Phonon.
>
>
> Repository: phonon
>
>
> Description
> -------
>
> This allows installing the architecture independent data outside
> the prefix, for example on a multiarch layout where the prefix
> is /usr/{host-triplet}.
>
>
> Diffs
> -----
>
> cmake/FindPhononInternal.cmake 44862b5
>
> Diff: https://git.reviewboard.kde.org/r/123232/diff/
>
>
> Testing
> -------
>
> Built, installed it and also built phonon-vlc against it.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150409/99dcb8b8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list