Review Request 123232: Use CMAKE_INSTALL_FULL_DATAROOTDIR

[Heiko Becker]

> On April 9, 2015, 8:22 vorm., Christophe Giboudeaux wrote:
> > See the comment in this request. This breaks the build.
> > 
> > Also note that CMAKE_INSTALL_DATAROOTDIR is defined by GNUInstallDirs which didn't exist in CMake 2.6.4 (which is the required version in Phonon(*))
> > 
> > (*) Despite what is in the top CMakeLists.txt, CMake 2.6.9 never existed

This commit http://quickgit.kde.org/?p=phonon.git&a=commit&h=d23f0ade0168eba6ef5f6fd52b1476d48e567bfc should have fixed it.


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123232/#review78695
-----------------------------------------------------------


On April 7, 2015, 11:17 nachm., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123232/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 11:17 nachm.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> This allows installing the architecture independent data outside
> the prefix, for example on a multiarch layout where the prefix
> is /usr/{host-triplet}.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 44862b5 
> 
> Diff: https://git.reviewboard.kde.org/r/123232/diff/
> 
> 
> Testing
> -------
> 
> Built, installed it and also built phonon-vlc against it.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150409/989a36d3/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia