Review Request 123232: Use CMAKE_INSTALL_FULL_DATAROOTDIR

[Harald Sitter]

> On April 5, 2015, 9:11 p.m., Aleix Pol Gonzalez wrote:
> > LGTM, shouldn't phonon be using ECM directly?
> 
> Heiko Becker wrote:
>     There are comments that it should probably be ported to ECM. If that is the consensus I would volunteer to do the work. I still think it would be good for this patch to go in until then.

Not sure it is worth the effort TBH.


- Harald


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123232/#review78541
-----------------------------------------------------------


On April 2, 2015, 9:25 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123232/
> -----------------------------------------------------------
> 
> (Updated April 2, 2015, 9:25 p.m.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> This allows installing the architecture independent data outside
> the prefix, for example on a multiarch layout where the prefix
> is /usr/{host-triplet}.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 44862b5 
> 
> Diff: https://git.reviewboard.kde.org/r/123232/diff/
> 
> 
> Testing
> -------
> 
> Built, installed it and also built phonon-vlc against it.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20150407/952fa088/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia