Review Request 110852: kscd: Improve MusicBrainz3 buildsys support

Rex Dieter rdieter at gmail.com
Sun May 11 13:47:42 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110852/
-----------------------------------------------------------

(Updated May 11, 2014, 12:47 p.m.)


Review request for KDE Multimedia.


Changes
-------

verified still applies to 4.13 branch


Bugs: 320808
    http://bugs.kde.org/show_bug.cgi?id=320808


Repository: kscd


Description
-------

Improve MusicBrainz3 buildsys support
- include directory is not used
- add pkgconfig hints


Diffs
-----

  CMakeLists.txt 8a2a8e5 
  cmake/FindMusicBrainz3.cmake e4bb814 

Diff: https://git.reviewboard.kde.org/r/110852/diff/


Testing
-------

Installed libmusicbrainz3 to non-standard include/libdir locations, build succeeds.


Thanks,

Rex Dieter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140511/e7d2242d/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list