Review Request 116763: Use KWallet to store scrobbling credentials.

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116763/#review53885
-----------------------------------------------------------

Ship it!


One fix was missed but other than that should be good to go. Thanks for your patience. :)


scrobbler.cpp
<https://git.reviewboard.kde.org/r/116763/#comment37770>

    This one still needs a QString::fromLatin1 conversion.


- Michael Pyne


On March 16, 2014, 8:54 a.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116763/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 8:54 a.m.)
> 
> 
> Review request for KDE Multimedia, Michael Pyne and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Use KWallet to store scrobbling credentials. If the KWallet is not available, or not allowed by the user, the old KConfigGroup code will be used. In the meanwhile, a dialog saying that the credentials will be saved in plain text will be shown.
> 
> 
> Diffs
> -----
> 
>   scrobbleconfigdlg.h 6674488 
>   scrobbleconfigdlg.cpp 7bcf19d 
>   scrobbler.h 5027459 
>   scrobbler.cpp 85da2e9 
> 
> Diff: https://git.reviewboard.kde.org/r/116763/diff/
> 
> 
> Testing
> -------
> 
> Manual testing on my laptop that uses KWallet and on my desktop that doesn't have KWallet. It seems to work in both cases.
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140324/186b2b17/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia