Review Request 112076: Fix bug where monitor won't powersave even with only audio content

James Smith smithjd15 at gmail.com
Wed Jun 25 09:32:58 BST 2014



> On June 24, 2014, 1:32 p.m., Harald Sitter wrote:
> > src/app/stateChange.cpp, line 195
> > <https://git.reviewboard.kde.org/r/112076/diff/11/?file=280473#file280473line195>
> >
> >     FWIW, this was supposed to read hasVideo rather than hasMedia ;)

The target function already reads hasVideo(). A check for hasMedia() keeps Dragon from crashing. Presumably checking hasVideo() doesn't IIRC.


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112076/#review60903
-----------------------------------------------------------


On June 24, 2014, 1:29 p.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112076/
> -----------------------------------------------------------
> 
> (Updated June 24, 2014, 1:29 p.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.cpp 0d18912 
>   src/app/stateChange.cpp 0edde72 
> 
> Diff: https://git.reviewboard.kde.org/r/112076/diff/
> 
> 
> Testing
> -------
> 
> Compile, run-test
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140625/e4d11d2e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list