Review Request 118545: ffmpegthumbs: Port to Frameworks

[Martin Tobias Holmedahl Sandsmark]

> On June 5, 2014, 10:58 a.m., David Faure wrote:
> > Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?
> 
> Hrvoje Senjan wrote:
>     i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...
> 
> David Faure wrote:
>     Unless I'm wrong, video/* didn't work in kdelibs4 either.
>     
>     (IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec).
> 
> Hrvoje Senjan wrote:
>     maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-)
>     but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely):
>     "Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"."
> 
> David Faure wrote:
>     ah it's a ThumbCreator, not an app, I see.
>     
>     kio/src/widgets/previewjob.cpp still supports video/*, see the variable "groupMimeType" in there. So it should work. You can debug it there if it doesn't :-)

AFAIK there aren't any video codecs or muxes that ffmpeg doesn't support (especially not any with a known mimetype), so IMHO video/* should stay.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/#review59312
-----------------------------------------------------------


On June 5, 2014, 10:47 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118545/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 10:47 a.m.)
> 
> 
> Review request for KDE Multimedia and David Faure.
> 
> 
> Repository: ffmpegthumbs
> 
> 
> Description
> -------
> 
> simple port to KF5.
> added Alex if he maybe has an idea why video/* doesn't seem to work.
> 
> 
> Diffs
> -----
> 
>   ffmpegthumbs.desktop 1e2a95a 
>   ffmpegthumbnailer/imagewriter.cpp 7dae371 
>   ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
>   ffmpegthumbnailer.cpp 03a40c3 
>   CMakeLists.txt dd0974f 
> 
> Diff: https://git.reviewboard.kde.org/r/118545/diff/
> 
> 
> Testing
> -------
> 
> Builds; thumbnails appear in Dolphin.
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140606/9966f7fb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia