Review Request 115124: Fix wrong computation of volume % value in muted state in tooltip

Commit Hook null at kde.org
Fri Jan 24 13:08:52 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115124/#review48206
-----------------------------------------------------------


This review has been submitted with commit 0849bc4556eba7f77bb840a4af1bd07416ebf45c by Burkhard Lück to branch master.

- Commit Hook


On Jan. 24, 2014, 1:07 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115124/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:07 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Hovering the mouse pointer over the volume icon at the right end of the toolbar
> two different tooltips are displayed depending on the mute state:
> State unmuted: Volume 81%
> State muted:   Volume 0,81% (muted) -> wrong computation of % value
> 
> 
> Diffs
> -----
> 
>   volumepopupbutton.cpp 5ac5e93 
> 
> Diff: https://git.reviewboard.kde.org/r/115124/diff/
> 
> 
> Testing
> -------
> 
> With patch the tooltip displays in muted state "Volume 81% (muted)" with the correct % value.
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140124/ac0577b6/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list