Review Request 115124: Fix wrong computation of volume % value in muted state in tooltip

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115124/#review47839
-----------------------------------------------------------

Ship it!


I did have a comment but the change looks fine either way, please commit whichever course you decide.


volumepopupbutton.cpp
<https://git.reviewboard.kde.org/r/115124/#comment33894>

    The change looks good but it might be prudent to remove the "muted ? i18n(...." portion at the end and just replace with 'i18n("(muted)")', because in this portion of the code we know that 'muted' must be true.
    
    It could even be lumped into the source string but since that would involve breaking i18n string freeze that would have to be up to the translation teams.


- Michael Pyne


On Jan. 19, 2014, 3:13 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115124/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 3:13 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Hovering the mouse pointer over the volume icon at the right end of the toolbar
> two different tooltips are displayed depending on the mute state:
> State unmuted: Volume 81%
> State muted:   Volume 0,81% (muted) -> wrong computation of % value
> 
> 
> Diffs
> -----
> 
>   volumepopupbutton.cpp 5ac5e93 
> 
> Diff: https://git.reviewboard.kde.org/r/115124/diff/
> 
> 
> Testing
> -------
> 
> With patch the tooltip displays in muted state "Volume 81% (muted)" with the correct % value.
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140120/94b2159a/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia