Review Request 114909: Make Dragon CanSetFullscreen mimic VLC

Harald Sitter sitter at kde.org
Thu Jan 16 05:38:34 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114909/#review47481
-----------------------------------------------------------

Ship it!


works as expected

video:
> Received reply from :1.107
>   Arguments: [Variant(bool): true]

audio:
> Received reply from :1.107
>  Arguments: [Variant(bool): false]

- Harald Sitter


On Jan. 16, 2014, 5:01 a.m., James Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114909/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2014, 5:01 a.m.)
> 
> 
> Review request for KDE Multimedia and Harald Sitter.
> 
> 
> Repository: dragon
> 
> 
> Description
> -------
> 
> Make Dragon hasVideo toggle CanSetFullscreen MPRIS2 property like VLC Media Player.
> 
> 
> Diffs
> -----
> 
>   src/mpris2/mediaplayer2.cpp 3cf1035 
> 
> Diff: https://git.reviewboard.kde.org/r/114909/diff/
> 
> 
> Testing
> -------
> 
> Compile, run
> 
> 
> Thanks,
> 
> James Smith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140116/5c06e361/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list