Review Request 110645: KMix: improve the appearance of the "Select Master Channel" dialogue

[Jonathan Marten]

> On Jan. 5, 2014, 7:37 p.m., Christian Esken wrote:
> > Hello Jonathan,
> > 
> > thanks for "ping-ing", as it is very easy too miss reviews. I checked the KDE HIG, and I would say your change is appropriate. From http://techbase.kde.org/Projects/Usability/HIG#Selection :
> >  - Use radio buttons for selection of 1 out of a few items.   <<< Current solution
> >  - Use a list view to select 1 singular item out of a potentially big list.   <<< proposed solution
> > 
> > 
> > I had not yet tested it, but is it still scrollable? This is required, as some cards have 30 or even 50 controls.

Yes, it is scrollable.  The list is a QListWidget which automatically gains scroll bars if required.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110645/#review46876
-----------------------------------------------------------


On May 25, 2013, 3:44 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110645/
> -----------------------------------------------------------
> 
> (Updated May 25, 2013, 3:44 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> The current dialogue, with its scolling list of radio buttons, does not look good and is not consistent with the channel lists as displayed elsewhere in KMix.  The buttons have no margin, the scrolling list is the same colour as the background, and there are no icons for visual cues.
> 
> This change displays the channels as a list, in the same way as the "Configure Channels" dialogue.  The current master channel shown by the highlighted item.
> 
> As an added bonus, the widget structure and code is simpler.
> 
> 
> Diffs
> -----
> 
>   gui/dialogselectmaster.h b79b56a 
>   gui/dialogselectmaster.cpp a5e5f45 
> 
> Diff: https://git.reviewboard.kde.org/r/110645/diff/
> 
> 
> Testing
> -------
> 
> Build KMix with these changes, checked appearance and operation of the dialogue with 2 different sound cards.
> 
> 
> File Attachments
> ----------------
> 
> Screen shot - before
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-before.png
> Screen shot - after
>   https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-after.png
> 
> 
> Thanks,
> 
> Jonathan Marten
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140112/bab8cd87/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia