Review Request 110092: Avoid pulse feedback v2

[Albert Astals Cid]

> On April 25, 2013, 12:03 a.m., vova7890 vova7890 wrote:
> > Ship It!
> 
> Myriam Schweingruber wrote:
>     Only core developers and maintainers are allowed to call "ship it", and never for your own review anyway :)
> 
> vova7890 vova7890 wrote:
>     know nothing, I have a clickable button and I clicked it! Remove their from me... :)
> 
> Albert Astals Cid wrote:
>     Can you please discard this request and resubmit a new review request so that we have a new one that has not been tainted by you giving yourself the ok?
> 
> Rex Dieter wrote:
>     tfischer did the initial ship it here, what's the problem?

Torrie did the initial ship it, and the vova7890 changed the code and gave himself a ship it. That's bad.

Anyway the patch does not apply anymore so it needs to be updated, and i'd suggest in a new review request.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110092/#review31524
-----------------------------------------------------------


On April 23, 2013, 5:03 p.m., vova7890 vova7890 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110092/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 5:03 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> Avoidin slider crazy behaviour on pulse feedbacks. v2 of https://projects.kde.org/projects/kde/kdemultimedia/kmix/repository/revisions/02e2021f692298abe74ad8ca1fdc03fac62c51a3. v2 use better way, of avoiding feedback on backend, and don`t touch guis.
> 
> 
> Diffs
> -----
> 
>   backends/mixer_pulse.h ac65534 
>   backends/mixer_pulse.cpp e08a881 
>   core/mixer.cpp 77c7dbc 
>   gui/mdwslider.h a9b056f 
>   gui/mdwslider.cpp 761e667 
> 
> Diff: https://git.reviewboard.kde.org/r/110092/diff/
> 
> 
> Testing
> -------
> 
> Tested. No have regression, work fine.
> 
> 
> Thanks,
> 
> vova7890 vova7890
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140112/d5aa68c8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia