Review Request 107822: Simplify layout of popup window to allow it grow when a new stream is added

[Christian Esken]

> On Jan. 2, 2014, 6:46 a.m., Christian Esken wrote:
> > Is this patch still relevant. It looks like we cannot remove QWidgetAction, so the patch cannot be used like it is. Additionally resizing works properly now when streams are added. For me it even works OK, if the tray popup is open at the moment a stream is started or ends.
> 
> Eugene Shalygin wrote:
>     Same with me. So I agree that this review request has to be abandoned.

Thanks for your feedback, Eugene. Can you close the review request please (only the original author can do that).


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107822/#review46592
-----------------------------------------------------------


On Jan. 2, 2013, 10:18 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/107822/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 10:18 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Bugs: 288637
>     http://bugs.kde.org/show_bug.cgi?id=288637
> 
> 
> Repository: kmix
> 
> 
> Description
> -------
> 
> Eliminate QWidgetAction from popup window that allows popup window to change its size. For instance, when a new stream is added, it grows now.
> 
> This might help to avoid recreation of the View (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h 0109086 
>   gui/kmixdockwidget.cpp 3bda22e 
>   gui/viewbase.h 9ef64bb 
>   gui/viewbase.cpp 9a9876c 
>   gui/viewdockareapopup.cpp 553c7bb 
> 
> Diff: https://git.reviewboard.kde.org/r/107822/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140104/98896d70/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia