Review Request 115718: Use MediaSource(const QUrl& url) instead of deprecated MediaSource(const QString& fileName)

Michael Pyne mpyne at kde.org
Sun Feb 16 17:49:42 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115718/#review49943
-----------------------------------------------------------

Ship it!


Looks good, sorry for the delay.

Are you able to commit yourself or do you need me to commit?

- Michael Pyne


On Feb. 16, 2014, 10:25 a.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115718/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 10:25 a.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Don't use the deprecated MediaSource(const QString& fileName) constructor anymore.
> 
> 
> Diffs
> -----
> 
>   playermanager.cpp 9042561 
> 
> Diff: https://git.reviewboard.kde.org/r/115718/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140216/acc60f68/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list