Review Request 121638: Make VideoWidget::snapshot work again

[Rohan Garg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121638/#review72444
-----------------------------------------------------------

Ship it!


Looks sensible to me, unless someone can come up with a better reason not to do this ( I couldn't find documentation anywhere about GST_VIDEO_NE, except for inside gst code itself, and no one, not even gst seems to be using this. )

- Rohan Garg


On Dec. 23, 2014, 6:58 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121638/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 6:58 a.m.)
> 
> 
> Review request for Phonon, Phonon Backends and Rohan Garg.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> I have no clue about gstreamer, but this works and the other not :D
> 
> 
> Diffs
> -----
> 
>   gstreamer/videowidget.cpp 5dd35cb 
> 
> Diff: https://git.reviewboard.kde.org/r/121638/diff/
> 
> 
> Testing
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=342140 works again
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20141223/0e3bc446/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia