Review Request 110645: KMix: improve the appearance of the "Select Master Channel" dialogue

Jonathan Marten jjm at
Sun Aug 10 12:02:08 BST 2014

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 10, 2014, 11:02 a.m.)


This change has been marked as submitted.

Review request for KDE Multimedia.

Repository: kmix


The current dialogue, with its scolling list of radio buttons, does not look good and is not consistent with the channel lists as displayed elsewhere in KMix.  The buttons have no margin, the scrolling list is the same colour as the background, and there are no icons for visual cues.

This change displays the channels as a list, in the same way as the "Configure Channels" dialogue.  The current master channel shown by the highlighted item.

As an added bonus, the widget structure and code is simpler.


  gui/dialogselectmaster.h b79b56a 
  gui/dialogselectmaster.cpp a5e5f45 



Build KMix with these changes, checked appearance and operation of the dialogue with 2 different sound cards.

File Attachments

Screen shot - before
Screen shot - after


Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list