Review Request 110645: KMix: improve the appearance of the "Select Master Channel" dialogue

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110645/
-----------------------------------------------------------

(Updated Aug. 10, 2014, 11:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Multimedia.


Repository: kmix


Description
-------

The current dialogue, with its scolling list of radio buttons, does not look good and is not consistent with the channel lists as displayed elsewhere in KMix.  The buttons have no margin, the scrolling list is the same colour as the background, and there are no icons for visual cues.

This change displays the channels as a list, in the same way as the "Configure Channels" dialogue.  The current master channel shown by the highlighted item.

As an added bonus, the widget structure and code is simpler.


Diffs
-----

  gui/dialogselectmaster.h b79b56a 
  gui/dialogselectmaster.cpp a5e5f45 

Diff: https://git.reviewboard.kde.org/r/110645/diff/


Testing
-------

Build KMix with these changes, checked appearance and operation of the dialogue with 2 different sound cards.


File Attachments
----------------

Screen shot - before
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-before.png
Screen shot - after
  https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-after.png


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140810/ab268fc1/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia