Review Request 119578: FindPhononInternal: Sync clang detection code with kdelibs.

Harald Sitter sitter at kde.org
Sun Aug 3 09:34:36 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119578/#review63696
-----------------------------------------------------------

Ship it!


Ship It!

- Harald Sitter


On Aug. 2, 2014, 11:11 nachm., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119578/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2014, 11:11 nachm.)
> 
> 
> Review request for Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> Pull in the following kdelibs commits:
>   daa54a2 Always enable exceptions when building with clang.
>   90cb7ba Move the clang compiler definitions to a separate block.
>   5ede522 clang: Pass additional compiler and linker flags on Linux/Hurd.
>   7148da9 Backport: Add basic support for clang in FindKDE4Internal.cmake.
> 
> This introduces proper support for clang in Phonon -- so far, it was
> being built without any changes to the default compiler and linker
> flags.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 3245e9befb21059dbb7361becd0a0d46f126945c 
> 
> Diff: https://git.reviewboard.kde.org/r/119578/diff/
> 
> 
> Testing
> -------
> 
> Phonon builds fine.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140803/a6bf3f5f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list