Review Request 117334: Fix bug 332963 - Crash when clicking on a music when the network is unavailable

Michael Pyne mpyne at kde.org
Wed Apr 2 21:06:50 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117334/#review54897
-----------------------------------------------------------

Ship it!


Ship It!

- Michael Pyne


On April 2, 2014, 1:01 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117334/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 1:01 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Bugs: 332963
>     http://bugs.kde.org/show_bug.cgi?id=332963
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> Fix bug 332963 - Crash when clicking on a music when the network is unavailable. Just check if the m_networkAcessManager instance is valid before using its post method.
> 
> 
> Diffs
> -----
> 
>   scrobbler.cpp f4ec51f 
> 
> Diff: https://git.reviewboard.kde.org/r/117334/diff/
> 
> 
> Testing
> -------
> 
> Yes, the bug is not reproducible anymore.
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20140402/60c92328/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list