Review Request 112721: Volume step should not be affected by wheelScrollLines

[Albert Vaca Cintora]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112721/
-----------------------------------------------------------

(Updated Sept. 14, 2013, 12:51 a.m.)


Status
------

This change has been discarded.


Review request for KDE Multimedia.


Description
-------

I noticed that changing the volume by scrolling over the KMix icon changed it in very big steps. I also realized that killing KDED made the step smaller and 'nicer' so I realized it might be a bug. I found that the scroll event was being called as many times as set in the setting "wheelScrollLines" ("Mouse wheel scrolls by [X] lines" in system settings). It makes sense when scrolling on documents, but not here, so I'm scaling the steps by that value so it always change in steps the same (smaller) size.


Diffs
-----

  gui/kmixdockwidget.h 0109086 
  gui/kmixdockwidget.cpp e84338e 

Diff: http://git.reviewboard.kde.org/r/112721/diff/


Testing
-------

Manual testing.


Thanks,

Albert Vaca Cintora

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130913/484111bb/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia