Review Request 112721: Volume step should not be affected by wheelScrollLines

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112721/#review40004
-----------------------------------------------------------


This has noble intentions, but isn't the right fix. The underlying bug is in Plasma's MouseEventListener QML component, which filters events on children and fires an event handler for each child the event passes through, which for the item hierarchy in the tray plasmoid causes each wheel move to run the event handler thrice.

https://bugs.kde.org/show_bug.cgi?id=316546 has a patch that addresses this, unfortunately the author has so far not reacted to requests to post it on ReviewBoard so we can include it with full attribution. The next step would be to write a cleanroom reimplementation and ship it.

- Eike Hein


On Sept. 13, 2013, 10:35 p.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112721/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 10:35 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> I noticed that changing the volume by scrolling over the KMix icon changed it in very big steps. I also realized that killing KDED made the step smaller and 'nicer' so I realized it might be a bug. I found that the scroll event was being called as many times as set in the setting "wheelScrollLines" ("Mouse wheel scrolls by [X] lines" in system settings). It makes sense when scrolling on documents, but not here, so I'm scaling the steps by that value so it always change in steps the same (smaller) size.
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h 0109086 
>   gui/kmixdockwidget.cpp e84338e 
> 
> Diff: http://git.reviewboard.kde.org/r/112721/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130913/a6737521/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia