Review Request 112076: Fix bug where monitor won't powersave even with only audio content

James Smith smithjd15 at gmail.com
Wed Sep 4 23:41:07 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112076/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 10:41 p.m.)


Review request for KDE Multimedia and Harald Sitter.


Changes
-------

No main window tinkering. This patch highlighted an issue where the MSN XMPP login window won't stop showing up in fullscreen mode over the video window despite KNotificationRestrictions which I thought broken during relocating to videoWindow. This ended up being in common with git master so hopefully that wasn't an issue and, the function could end up deprecated successfully in favour of the simplified suppressScreenPowerManagement behaviour, or retained until more options become available to suppress such notifications.


Description
-------

Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.


Diffs (updated)
-----

  src/app/audioView2.h 6c04b47 
  src/app/audioView2.cpp f2ddc44 
  src/app/mainWindow.h 51ef72c 
  src/app/mainWindow.cpp f850820 
  src/app/stateChange.cpp 0edde72 
  src/app/videoWindow.h ab61ed0 
  src/app/videoWindow.cpp a325a6e 

Diff: http://git.reviewboard.kde.org/r/112076/diff/


Testing
-------

Compile, run-test


Thanks,

James Smith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130904/2a76b123/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list