Review Request 112434: Properly detect the location of STL's shared_ptr.

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112434/#review39209
-----------------------------------------------------------

Ship it!


Looks like proper detection and "#ifdef-ing". Like review request 112433, please ship. Thanks.

- Christian Esken


On Sept. 1, 2013, 8:07 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112434/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2013, 8:07 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> Properly detect the location of STL's shared_ptr.
> 
> std::shared_ptr is a C++11 feature, whose location (and existence) in STL
> implementations of previous C++ standards varied -- one widespread example
> is GCC's libstdc++, which has a shared_ptr implementation in <tr1/memory>
> that was shipped long before C++11.
> 
> However, including it unconditionally breaks the build if any other STL
> implementation (such as libc++) is used instead.
> 
> We now check if std::shared_ptr is present in the <memory> header and then
> try std::tr1::shared_ptr as a fallback.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a442972cf27305a4048f9fd4133f496392e87d60 
>   config.h.cmake 032f8c101a192dd6769944c0f4978ef673557cae 
>   core/ControlPool.h 4cb2222f46e9ed855bfbe028fe1c124f683d8f8a 
>   core/MasterControl.h dff9e95d719508a8966d1d9c994948851d5bd2c8 
>   core/mixdevice.h f5ca7829b78709569ea7749aea8d781870cec409 
> 
> Diff: http://git.reviewboard.kde.org/r/112434/diff/
> 
> 
> Testing
> -------
> 
> Together with <https://git.reviewboard.kde.org/r/112433> building KMix with clang and libc++ finally succeeds.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130902/6919224e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia