Review Request 113125: display a notification when JuK starts docked in system tray

Michael Pyne mpyne at kde.org
Sun Oct 6 23:23:00 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113125/#review41312
-----------------------------------------------------------

Ship it!


This patch looks good, are you able to commit Shubham?

- Michael Pyne


On Oct. 5, 2013, 11:51 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113125/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2013, 11:51 p.m.)
> 
> 
> Review request for KDE Multimedia and Michael Pyne.
> 
> 
> Bugs: 316832
>     http://bugs.kde.org/show_bug.cgi?id=316832
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> To display a notification explaining steps to restore JuK back from system tray.
> 
> Bug 316832 - JuK starts off miminized to tray, which is confusing--no main window is seen
> 
> 
> Diffs
> -----
> 
>   juk.notifyrc cf4df1b 
>   main.cpp d542403 
> 
> Diff: http://git.reviewboard.kde.org/r/113125/diff/
> 
> 
> Testing
> -------
> 
> Manually tested multiple times using KDE Development Platform 4.11.2
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131006/0d763f89/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list