Review Request 114216: [GCI] Update JuK Copyright headers and fill any missing information

Michael Pyne mpyne at kde.org
Sat Nov 30 02:26:18 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114216/#review44863
-----------------------------------------------------------

Ship it!


Lots of good work, I hope it was automated though. :)

I will go ahead and review/apply as there are a couple of other things I would want to fix while we're making this kind of change (e.g. email addresses). Thanks!


scrobbler.h
<http://git.reviewboard.kde.org/r/114216/#comment32068>

    Seems there was an extra space placed here near the right. But that's easy to fix.


- Michael Pyne


On Nov. 29, 2013, 9:38 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114216/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2013, 9:38 p.m.)
> 
> 
> Review request for KDE Multimedia, Michael Pyne and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: juk
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2013/5240843917066240
> Author: Eric Newberry
> 
> 
> Diffs
> -----
> 
>   actioncollection.h 7e29602 
>   actioncollection.cpp 8fa8430 
>   advancedsearchdialog.h ddcbde7 
>   advancedsearchdialog.cpp 99d0b01 
>   cache.h 2c33336 
>   cache.cpp b086571 
>   categoryreaderinterface.h 28f1a52 
>   categoryreaderinterface.cpp 543f30a 
>   collectionlist.h 1bda6c1 
>   collectionlist.cpp 1b2d076 
>   coverdialog.h bef3caa 
>   coverdialog.cpp abde420 
>   covericonview.h bcd37e4 
>   covericonview.cpp 5988568 
>   coverinfo.h 230c0d1 
>   coverinfo.cpp 2dac3cd 
>   covermanager.h 408bfc8 
>   covermanager.cpp a97f03c 
>   coverproxy.h e9811cc 
>   coverproxy.cpp 36d72ff 
>   dbuscollectionproxy.h 7800537 
>   dbuscollectionproxy.cpp bc2dfb2 
>   deletedialog.h 419217f 
>   deletedialog.cpp 12e3039 
>   directorylist.h 5736415 
>   directorylist.cpp ed89ce3 
>   dynamicplaylist.h 85d7b71 
>   dynamicplaylist.cpp d0ce0fe 
>   exampleoptions.h b097c46 
>   exampleoptions.cpp bf57744 
>   filehandle.h fb62d49 
>   filehandle.cpp 78571b1 
>   filehandleproperties.h 4de4250 
>   filerenamer.h abc42b2 
>   filerenamer.cpp b9907a0 
>   filerenamerconfigdlg.h 38f0b4d 
>   filerenamerconfigdlg.cpp be23fdd 
>   filerenameroptions.h 1df871d 
>   filerenameroptions.cpp 20a2b06 
>   folderplaylist.h 3b30684 
>   folderplaylist.cpp 3dc727e 
>   historyplaylist.h d5b903f 
>   historyplaylist.cpp 614c682 
>   juk-exception.h c86afeb 
>   juk.h 488aaaf 
>   juk.cpp a1da0ae 
>   jukIface.h 7ce5557 
>   k3bexporter.h e4c7f4d 
>   k3bexporter.cpp 6a98cb0 
>   keydialog.h 3f18337 
>   keydialog.cpp 8464365 
>   ktrm.h ee5f732 
>   ktrm.cpp fa85490 
>   lyricswidget.h 8e8d030 
>   lyricswidget.cpp 7bb591a 
>   main.cpp c41f96a 
>   mediafiles.h 8b9d90a 
>   mediafiles.cpp 400f1c7 
>   musicbrainzquery.h db1f7bb 
>   musicbrainzquery.cpp da97140 
>   nowplaying.h 9321b78 
>   nowplaying.cpp 85f4ba1 
>   playermanager.h 9b3f177 
>   playermanager.cpp 33171d9 
>   playlist.h 13db5ba 
>   playlist.cpp 6fa65e1 
>   playlistbox.h 7077313 
>   playlistbox.cpp 857c0d7 
>   playlistcollection.h 0f2a40d 
>   playlistcollection.cpp a63935e 
>   playlistexporter.h 85c3d30 
>   playlistexporter.cpp af2c400 
>   playlistinterface.h 966339b 
>   playlistinterface.cpp 28ae0a0 
>   playlistitem.h 7291794 
>   playlistitem.cpp a8a408e 
>   playlistsearch.h e5e64c4 
>   playlistsearch.cpp 1f86138 
>   playlistsplitter.h 8985d12 
>   playlistsplitter.cpp 9fc99f4 
>   scrobbleconfigdlg.h 8be1589 
>   scrobbleconfigdlg.cpp 3ced8de 
>   scrobbler.h c2e1654 
>   scrobbler.cpp 0c5a5b9 
>   searchplaylist.h a5de27d 
>   searchplaylist.cpp 9d1db4d 
>   searchwidget.h 73c7a22 
>   searchwidget.cpp 5efe720 
>   slideraction.h d2e620d 
>   slideraction.cpp afc6aa0 
>   sortedstringlist.h d80ce6b 
>   sortedstringlist.cpp 60d6e32 
>   splashscreen.h f1d61ae 
>   splashscreen.cpp bd1706e 
>   statuslabel.h 6a65e1e 
>   statuslabel.cpp f482033 
>   stringhash.h 281e482 
>   stringshare.h 902e413 
>   stringshare.cpp bfe9498 
>   systemtray.h 45d9ff4 
>   systemtray.cpp 6e8e912 
>   tag.h 00195ed 
>   tag.cpp 4e36e3c 
>   tageditor.h 017ab42 
>   tageditor.cpp 66117e8 
>   tagguesser.h 99fec20 
>   tagguesser.cpp 3e7a602 
>   tagguesserconfigdlg.h f9357d3 
>   tagguesserconfigdlg.cpp 476bf0b 
>   tagrenameroptions.h b5bf8e8 
>   tagrenameroptions.cpp cb40dd4 
>   tagtransactionmanager.h 0ffb4d5 
>   tagtransactionmanager.cpp c231833 
>   trackpickerdialog.h f5e7311 
>   trackpickerdialog.cpp 0412752 
>   tracksequenceiterator.h c25cf46 
>   tracksequenceiterator.cpp 2961b8c 
>   tracksequencemanager.h 7c1cd76 
>   tracksequencemanager.cpp bdc0615 
>   treeviewitemplaylist.h 90b8aca 
>   treeviewitemplaylist.cpp f4b1f20 
>   upcomingplaylist.h 16293c7 
>   upcomingplaylist.cpp 6d328b6 
>   viewmode.h 5182641 
>   viewmode.cpp b3f1239 
>   webimagefetcher.h b8747da 
>   webimagefetcher.cpp a551706 
> 
> Diff: http://git.reviewboard.kde.org/r/114216/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131130/1cecf782/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list