Review Request 114217: ebn krazy fixes in JuK

Shubham Chaudhary shubhamchaudhary92 at gmail.com
Fri Nov 29 21:56:56 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114217/
-----------------------------------------------------------

Review request for KDE Multimedia and Michael Pyne.


Repository: juk


Description
-------

Changes: 
* single quote chars
* casted floats to qBound
* KUrl instead of QUrl
* removed empty spaces
* added newline at eof


Diffs
-----

  lyricswidget.cpp 7bb591a 
  mpris2/mediaplayer2player.cpp fe9b6b7 
  scrobbleconfigdlg.h 8be1589 
  scrobbler.cpp 0c5a5b9 
  volumepopupbutton.cpp 5ac5e93 

Diff: http://git.reviewboard.kde.org/r/114217/diff/


Testing
-------

build and run


Thanks,

Shubham Chaudhary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131129/0b21ab39/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list