Review Request 113649: fix rpath handling

[Alexander Neundorf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113649/#review43084
-----------------------------------------------------------


If LIB_INSTALL_DIR is a cache variable, i.e. if it can be set from the outside (I guess it can), you should test before whether it is an 
absolute path or not, and make it absolute if it isn't:

set(_abs_LIB_INSTALL_DIR "${LIB_INSTALL_DIR}")
  if (NOT IS_ABSOLUTE "${_abs_LIB_INSTALL_DIR}")
     set(_abs_LIB_INSTALL_DIR "${CMAKE_INSTALL_PREFIX}/${LIB_INSTALL_DIR}")
  endif()


- Alexander Neundorf


On Nov. 5, 2013, 4:38 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113649/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2013, 4:38 p.m.)
> 
> 
> Review request for Build System and Phonon.
> 
> 
> Repository: phonon
> 
> 
> Description
> -------
> 
> Prior to this patch, the cmake code queries/uses ${LIB_INSTALL_DIR} which is a relative path, so an unconditional (relative) rpath gets added.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake b48bfaf 
> 
> Diff: http://git.reviewboard.kde.org/r/113649/diff/
> 
> 
> Testing
> -------
> 
> build/install phonon-4.7.0 to system path on fedora 20 without rpath.
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131105/a1c3af74/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-buildsystem mailing list
Kde-buildsystem at kde.org
https://mail.kde.org/mailman/listinfo/kde-buildsystem