Review Request 110381: Add 'Play Stream' functionality
Harald Sitter
sitter at kde.org
Fri May 10 17:28:52 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110381/#review32324
-----------------------------------------------------------
the bottom left media indication in the statusbar at the very least will need to elide, otherwise this has bad side effects when a user tries to play a stream with a longish URL (i.e. window becomes as wide as necessary to accommodate the url)
src/app/mainWindow.cpp
<http://git.reviewboard.kde.org/r/110381/#comment24045>
please use i18nc http://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics
- Harald Sitter
On May 10, 2013, 10:46 a.m., Andrea Scarpino wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110381/
> -----------------------------------------------------------
>
> (Updated May 10, 2013, 10:46 a.m.)
>
>
> Review request for KDE Multimedia.
>
>
> Description
> -------
>
> Adds a 'Play Stream' button, in the Play Media widget, that calls an input dialog to get the stream url.
>
> Everyday I use dragon to play youtube videos without flashplugin, but everytime I've to start it from the konsole as 'Open File' do not accept links.
>
>
> Diffs
> -----
>
> src/app/loadView.h e11f7fd
> src/app/loadView.cpp 01af7c3
> src/app/loadView.ui 2fa6151
> src/app/mainWindow.h 5f79573
> src/app/mainWindow.cpp b47e279
>
> Diff: http://git.reviewboard.kde.org/r/110381/diff/
>
>
> Testing
> -------
>
> Correctly played a youtube video.
>
>
> File Attachments
> ----------------
>
> Button and input dialog
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/play-stream.png
>
>
> Thanks,
>
> Andrea Scarpino
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130510/116a44a3/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
More information about the kde-multimedia
mailing list