Review Request 109293: Fix carshes when moving stream across devices

[Colin Guthrie]

> On March 5, 2013, 3:46 p.m., Stephan Diestelhorst wrote:
> > I'd say ship it.  It fixes a nasty KDE 4.10 regression (bug 311167 https://bugs.kde.org/show_bug.cgi?id=311167) in kmix and has been confirmed to work on both Kubuntu and ArchLinux by several users.  No ill-effects have been observed either.  We should at least aim for 4.10.2 (although 4.10.1 would be ideal).
> 
> Stephan Diestelhorst wrote:
>     Updating, since I added myself to the ML.

Yup, a similar fix for other things was done a while ago (can't remember if it was here or in Phonon tho). Ship it!!


- Colin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109293/#review28586
-----------------------------------------------------------


On March 5, 2013, 3:39 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109293/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 3:39 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> The crash, described in the referenced bug, seems to be caused by deleting menu objects from menu action handlers, since KMix completele rebuilds UI elements on reaction to stream move. By changing signal connection type to QueuedConnection, we just scheduling move from the handler (which is always called via user input event). Thus, UI rebuild will happen later and crash is avoided.
> 
> 
> This addresses bug 311167.
>     http://bugs.kde.org/show_bug.cgi?id=311167
> 
> 
> Diffs
> -----
> 
>   gui/mdwslider.cpp 5572d63 
> 
> Diff: http://git.reviewboard.kde.org/r/109293/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130305/352c7870/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia