Review Request 109293: Fix carshes when moving stream across devices

[Colin Guthrie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109293/#review28601
-----------------------------------------------------------

Ship it!


Ship It!

- Colin Guthrie


On March 5, 2013, 3:39 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109293/
> -----------------------------------------------------------
> 
> (Updated March 5, 2013, 3:39 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> The crash, described in the referenced bug, seems to be caused by deleting menu objects from menu action handlers, since KMix completele rebuilds UI elements on reaction to stream move. By changing signal connection type to QueuedConnection, we just scheduling move from the handler (which is always called via user input event). Thus, UI rebuild will happen later and crash is avoided.
> 
> 
> This addresses bug 311167.
>     http://bugs.kde.org/show_bug.cgi?id=311167
> 
> 
> Diffs
> -----
> 
>   gui/mdwslider.cpp 5572d63 
> 
> Diff: http://git.reviewboard.kde.org/r/109293/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130305/d99b1070/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia