Review Request 111646: Make MPRIS2 asynchronously, fix some memory leaks

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111646/
-----------------------------------------------------------

(Updated July 22, 2013, 11:02 p.m.)


Review request for KDE Multimedia and Christian Esken.


Description (updated)
-------

Make MPRIS2 asynchronously, fix some memory leaks, and cleanups. This review request is here, as I committed my changes to trunk after KDE4.11 was branched and would like to see the changes in KDE4.11. The patch contains all changes of trunk done after branching (except the very last, which is harmless but big due to source code reformatting).

Most important (and biggest) change is in the mixer_mpris2.cpp/h files. But due to dependencies I could not simply use the changes in mixer_mpris2.cpp/h as a patch. In the end trunk could be copied to 4.11 (instead of this patch applied).


Diffs
-----

  apps/kmix.cpp 8fdcf73 
  backends/mixer_alsa9.cpp b94bf1d 
  backends/mixer_alsa9.cpp 5004f06 
  backends/mixer_mpris2.h 18e2b18 
  backends/mixer_mpris2.h 0e530c8 
  backends/mixer_mpris2.cpp 1864125 
  backends/mixer_mpris2.cpp 58dad3a 
  backends/mixer_mpris2.cpp 77f00be 
  backends/mixer_mpris2.cpp ae094c8 
  backends/mixer_pulse.cpp d043ec4 
  core/mixdevice.h 177c3b2 
  core/mixdevice.h a59c9b9 
  core/mixdevice.h e87947e 
  core/mixdevice.cpp 06b883e 
  core/mixdevice.cpp 5100991 
  core/mixdevice.cpp 5f09c8b 
  core/mixertoolbox.h 2e396d0 
  core/mixertoolbox.cpp 481e0f3 
  core/mixertoolbox.cpp 5c11dab 
  gui/guiprofile.h ac5a11f 
  gui/guiprofile.cpp 6b43194 
  gui/mdwslider.cpp 42318a3 
  gui/mdwslider.cpp dfb4009 
  gui/osdwidget.cpp 72b8d9c 
  gui/viewdockareapopup.cpp cefd8d1 
  gui/viewsliders.cpp c8c9f78 

Diff: http://git.reviewboard.kde.org/r/111646/diff/


Testing
-------


Thanks,

Christian Esken

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130722/55f30ef2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia