Review Request 110852: kscd: Improve MusicBrainz3 buildsys support

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110852/#review35480
-----------------------------------------------------------


Thanks for your patch. I remember a discussion about porting the code to MusicBrainz version 5 (which is already used by libkcddb), but could not find it. openSUSE currently ships with three MusicBrainz versions already, so it's probably time to move forward.

Any kdemultimedia developer looking for a junior job? :) I think k3b fails to handle MusicBrainz 5, too.

Otherwise, I suggest to commit this, but probably a kdemultimedia developer should approve.

- Christoph Feck


On June 6, 2013, 5:48 p.m., Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110852/
> -----------------------------------------------------------
> 
> (Updated June 6, 2013, 5:48 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Improve MusicBrainz3 buildsys support
> - include directory is not used
> - add pkgconfig hints
> 
> 
> This addresses bug 320808.
>     http://bugs.kde.org/show_bug.cgi?id=320808
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 8a2a8e5 
>   cmake/FindMusicBrainz3.cmake e4bb814 
> 
> Diff: http://git.reviewboard.kde.org/r/110852/diff/
> 
> 
> Testing
> -------
> 
> Installed libmusicbrainz3 to non-standard include/libdir locations, build succeeds.
> 
> 
> Thanks,
> 
> Rex Dieter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130702/7a510ad2/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia