Review Request: Simplify layout of popup window to allow it grow when a new stream is added

Eugene Shalygin eugene.shalygin at gmail.com
Wed Jan 2 22:18:47 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107822/
-----------------------------------------------------------

(Updated Jan. 2, 2013, 10:18 p.m.)


Review request for KDE Multimedia and Christian Esken.


Changes
-------

merge http://git.reviewboard.kde.org/r/107831/


Description
-------

Eliminate QWidgetAction from popup window that allows popup window to change its size. For instance, when a new stream is added, it grows now.

This might help to avoid recreation of the View (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?


This addresses bug 288637.
    http://bugs.kde.org/show_bug.cgi?id=288637


Diffs (updated)
-----

  gui/kmixdockwidget.h 0109086 
  gui/kmixdockwidget.cpp 3bda22e 
  gui/viewbase.h 9ef64bb 
  gui/viewbase.cpp 9a9876c 
  gui/viewdockareapopup.cpp 553c7bb 

Diff: http://git.reviewboard.kde.org/r/107822/diff/


Testing
-------

Manual


Thanks,

Eugene Shalygin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130102/5c499d63/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list