Review Request: Shrink popup window after removing mixers or streams

Eugene Shalygin eugene.shalygin at gmail.com
Wed Jan 2 21:54:38 GMT 2013



> On Jan. 2, 2013, 9:31 p.m., Christian Esken wrote:
> > This patch is to be done after the patch from review 107822 has been applied. Both patches/reviews could be merged if I understood them right.

Yes and yes. I've pointed the patch from review 107822 as a "previous diff" for the reviewboard, as I thought it will sort out this automatically. Seems like it does not. Shall I update  review 107822 with the united patch?


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107831/#review24510
-----------------------------------------------------------


On Dec. 21, 2012, 1:08 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107831/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 1:08 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> When stream is removed while popup is visible, the popup window did not change its size. This is a simple solution.
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h 0109086 
>   gui/kmixdockwidget.cpp 3bda22e 
>   gui/viewbase.h 9ef64bb 
>   gui/viewbase.cpp 9a9876c 
>   gui/viewdockareapopup.cpp 0d3b827 
> 
> Diff: http://git.reviewboard.kde.org/r/107831/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130102/98e3d2ea/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list