Review Request: Simplify layout of popup window to allow it grow when a new stream is added

[Christian Esken]

> On Jan. 2, 2013, 7:11 p.m., Christian Esken wrote:
> > I do not see any changes about resizing the Sound Menu.
> >  - With ALSA + MPRIS2 it worked before and after the patch
> >  - With Pulseaudio it neither works before or after the patch
> >
> 
> Eugene Shalygin wrote:
>     Thank you for the test. I'm confused. I have 4 patches applied to KMix right now and the popup window grows and shrinks. Will compile it with the this one only and check in a few moments
> 
> Eugene Shalygin wrote:
>     Christian,
>     
>     I've applied this patch and my patch from https://bugs.kde.org/show_bug.cgi?id=288637 (to see new pulseaudio streams) and it works.
>     Obviously, without the patch from bugzilla I did not see new streams at all. With the path from bugzilla only, new streams are added, but the poup window retains its size.
>     
>     Sory, I can not test ALSA/MPRIS2 case.

I should probably add that that is basically a good thing. It does not break that functionality. If the rest of the tests are OK and it fixes the crash we are probably good to go.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107822/#review24483
-----------------------------------------------------------


On Dec. 20, 2012, 8:20 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107822/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 8:20 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> Eliminate QWidgetAction from popup window that allows popup window to change its size. For instance, when a new stream is added, it grows now.
> 
> This might help to avoid recreation of the View (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?
> 
> 
> This addresses bug 288637.
>     http://bugs.kde.org/show_bug.cgi?id=288637
> 
> 
> Diffs
> -----
> 
>   gui/kmixdockwidget.h 0109086 
>   gui/kmixdockwidget.cpp 3bda22e 
> 
> Diff: http://git.reviewboard.kde.org/r/107822/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130102/4c04e0fa/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia