[kscd] [Bug 303447] libkcddb and libkcompactdisc are not required to build kscd

[Pino Toscano]

https://bugs.kde.org/show_bug.cgi?id=303447

Pino Toscano <pino at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |4.10.1
      Latest Commit|http://commits.kde.org/kscd |http://commits.kde.org/kscd
                   |/260f116e1f5d497c92094abeab |/11ff6cae25479828e3b39ba1a5
                   |86d1da4b7f2f63              |96a3ccdfa48b91

--- Comment #2 from Pino Toscano <pino at kde.org> ---
Git commit 11ff6cae25479828e3b39ba1a596a3ccdfa48b91 by Pino Toscano, on behalf
of Michael Pyne.
Committed on 15/07/2012 at 01:27.
Pushed by pino into branch 'KDE/4.10'.

Remove references to non-required kde-mm libs.

Bug 303447 claims that libkcddb and libkcompactdisc are both not
actually used by kscd, and should be removed from CMakeLists.txt.

I've done what I can to prove the reporter wrong, including:

- Code review (looking for usage of headers from classes exported by
libkcddb and libkcompactdisc)
- Building kscd without CMake references to either lib.
- Running ldd on the resulting executable to verify the report that the
  libraries are not used by the binary.
- Actually *using* kscd (with an external CD player no less) after the
  aforementioned changes. The track list even shows up so CDDB data is
  being read from somewhere.

I'm convinced now. kscd does not directly require either libkcompactdisc
(Solid appears to be used instead) or libkcddb (MusicBrainz3 is used).
It is possible that those two libs are indirectly used but kscd doesn't
care at this point.
FIXED-IN: 4.10.1

(cherry picked from commit 260f116e1f5d497c92094abeab86d1da4b7f2f63)

Conflicts:
    CMakeLists.txt

M  +1    -8    CMakeLists.txt
M  +0    -2    kscd.kcfg

http://commits.kde.org/kscd/11ff6cae25479828e3b39ba1a596a3ccdfa48b91

-- 
You are receiving this mail because:
You are the assignee for the bug.