Review Request 108653: Do not restore the position in the sidebar if the video is old

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108653/#review27321
-----------------------------------------------------------


I really like that approach, it's much more smart (and we love smart things) than a clumsy setting saying "Auto-resume". I am not sure whether we should expose that config option to the user (given that Dragon hasn't got any settings) but having it changeable editing the config files should work for those who want that. And not sure if 30 days isn't too long.
Also, I think we need some auto-prune feature so the config file where the last playback date is stored doesn't get full with files I once watched and deleted/forgot.

- Kai Uwe Broulik


On Jan. 29, 2013, 10:28 a.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108653/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 10:28 a.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> This patch allow dragon to not restore the cursor position in the sidebar if the video has been opened one month ago.
> 
> We could also make this time configurable in the settings (e.g. "Expires profiles after 30 days").
> 
> 
> This addresses bug 251921.
>     http://bugs.kde.org/show_bug.cgi?id=251921
> 
> 
> Diffs
> -----
> 
>   src/app/mainWindow.h 60dfcf6 
>   src/app/mainWindow.cpp 55e89df 
>   src/app/videoWindow.cpp a87715f 
> 
> Diff: http://git.reviewboard.kde.org/r/108653/diff/
> 
> 
> Testing
> -------
> 
> Build, open a video, move the cursor, close dragon, change the Date line in the rc, open the video again.
> The video starts from the begin.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130212/9c1024d8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia