[kscd] [Bug 329121] KsCD crashes when skip is pressed before play

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=329121

Harald Sitter <sitter at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |0.7.2
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/phon
                   |                            |on-vlc/01d7ad7dce3f3c596642
                   |                            |ab0b6b74dd8a2826f3fe

--- Comment #1 from Harald Sitter <sitter at kde.org> ---
Git commit 20f27ab99b68cf25408488cd9578603a5a7805d1 by Harald Sitter.
Committed on 23/12/2013 at 08:31.
Pushed by sitter into branch '0.7'.

init and reset m_media variables to 0

this ensures obvious backtraces when running into unintended code paths.

M  +3    -1    src/media.cpp
M  +1    -0    src/mediaplayer.cpp

http://commits.kde.org/phonon-vlc/20f27ab99b68cf25408488cd9578603a5a7805d1

--- Comment #2 from Harald Sitter <sitter at kde.org> ---
Git commit 01d7ad7dce3f3c596642ab0b6b74dd8a2826f3fe by Harald Sitter.
Committed on 23/12/2013 at 08:38.
Pushed by sitter into branch '0.7'.

protect MediaPlayer::setCdTrack against bogus m_media accesses

this *probably* caused a crash when trying to set a track on a newly
created MO. m_media up until now was not initialized to 0 so it is
possible that setCdTrack was run on an invalid Media object.
outside this init case there is no point where either m_media or the
underlying vlc media would silently get a bogus value (see MP::setMedia,
Media::Media).
FIXED-IN: 0.7.2

M  +2    -0    src/mediaplayer.cpp

http://commits.kde.org/phonon-vlc/01d7ad7dce3f3c596642ab0b6b74dd8a2826f3fe

-- 
You are receiving this mail because:
You are the assignee for the bug.