Review Request 114417: CMake HAVE_ macro instead of os specific macro

[Harsh Kumar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114417/
-----------------------------------------------------------

Review request for KDE Multimedia.


Repository: dragon


Description
-------

OS specific macro __FreeBSD__ replaced by HAVE_SYS_TYPES_H which is defined by CMake.


Diffs
-----

  CMakeLists.txt 5d97021 
  config.h.cmake d820ea1 
  src/app/analyzer/analyzerBase.h 594d62d 

Diff: http://git.reviewboard.kde.org/r/114417/diff/


Testing
-------

I don't have Free BSD installed, so cannot test on it. Though it compiles on Linux.

Note: Presently, sys/types.h is to be included in case of Free BSD only. However, in linux, CMake is able to find sys/types.h & therefore it is included. I don't know if this is desirable or not.


Thanks,

Harsh Kumar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20131212/94d86c8e/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia