Review Request 114417: CMake HAVE_ macro instead of os specific macro

Harsh Kumar harsh1kumar at
Thu Dec 12 11:34:46 GMT 2013

This is an automatically generated e-mail. To reply, visit:

Review request for KDE Multimedia.

Repository: dragon


OS specific macro __FreeBSD__ replaced by HAVE_SYS_TYPES_H which is defined by CMake.


  CMakeLists.txt 5d97021 
  config.h.cmake d820ea1 
  src/app/analyzer/analyzerBase.h 594d62d 



I don't have Free BSD installed, so cannot test on it. Though it compiles on Linux.

Note: Presently, sys/types.h is to be included in case of Free BSD only. However, in linux, CMake is able to find sys/types.h & therefore it is included. I don't know if this is desirable or not.


Harsh Kumar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
kde-multimedia mailing list
kde-multimedia at

More information about the kde-multimedia mailing list