Review Request 110092: Avoid pulse feedback v2

[Trever Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110092/#review31448
-----------------------------------------------------------

Ship it!


Ship It!


backends/mixer_pulse.cpp
<http://git.reviewboard.kde.org/r/110092/#comment23439>

    Code like this can sometimes be confusing to read. I suggest changing it to p->updates -= 1


- Trever Fischer


On April 19, 2013, 10:10 p.m., vova7890 vova7890 wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110092/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 10:10 p.m.)
> 
> 
> Review request for KDE Multimedia.
> 
> 
> Description
> -------
> 
> Avoidin slider crazy behaviour on pulse feedbacks. v2 of https://projects.kde.org/projects/kde/kdemultimedia/kmix/repository/revisions/02e2021f692298abe74ad8ca1fdc03fac62c51a3. v2 use better way, of avoiding feedback on backend, and don`t touch guis.
> 
> 
> Diffs
> -----
> 
>   backends/mixer_pulse.h ac65534 
>   backends/mixer_pulse.cpp e08a881 
>   core/mixer.cpp 77c7dbc 
>   gui/mdwslider.h a9b056f 
>   gui/mdwslider.cpp 761e667 
> 
> Diff: http://git.reviewboard.kde.org/r/110092/diff/
> 
> 
> Testing
> -------
> 
> Tested. No have regression, work fine.
> 
> 
> Thanks,
> 
> vova7890 vova7890
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20130423/bf178980/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia