Review Request: Fix select master channel for multiple cards

[Christian Esken]

> On Sept. 20, 2012, 3:39 p.m., Christian Esken wrote:
> > Basically the patch seems like a good approach. I'll put it on my Agenda for the KDE MM Sprint in Randa end of Spetmber 2012.
> 
> Michal Humpula wrote:
>     Thanks for review! btw, why did it took so looooooong?:o)

Looks good. I found that the initial preselection of the ComboBox was also using readableName() instead of id(), so I changed that too.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105496/#review19228
-----------------------------------------------------------


On July 9, 2012, 8:08 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105496/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 8:08 p.m.)
> 
> 
> Review request for KDE Multimedia and Christian Esken.
> 
> 
> Description
> -------
> 
> On some settups where there are multiple soundcards with simillar name, the master select dialog get's confused to which card to assign the master channel. The patch is using Mixer->id() instead of readableName().
> 
> 
> Diffs
> -----
> 
>   gui/dialogselectmaster.cpp a5e5f45 
> 
> Diff: http://git.reviewboard.kde.org/r/105496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20120921/e82d244c/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia