Review Request: Port Phonon five build system to ECM and Qt5Transitional.cmake

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106970/#review21251
-----------------------------------------------------------


The circular dependency (due to libinqt5 being in kdelibs currently) will make building a bit harder though. Shouldn't ECM be fixed NOT to require libinqt5?

- David Faure


On Oct. 20, 2012, 6:56 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106970/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 6:56 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> This patch is based on my "Phonon five merge and cleanup" patch, and is a step towards building Phonon five on Qt5.
> 
> On Qt4 the build system will now insist on "libinqt5" being installed,
> which is located in the kdelibs repository in the frameworks branch.
> There is, however, no dependancy on the actual KDE Frameworks 5, and
> libinqt5 can be build and installed standalone.
> 
> 
> Diffs
> -----
> 
>   cmake/FindPhononInternal.cmake 20220a3 
>   demos/metadatareader/CMakeLists.txt fe6eb60 
>   demos/phota/CMakeLists.txt 2306c7e 
>   demos/simplecapture/CMakeLists.txt 4a2e1b0 
>   demos/simpleplayer/CMakeLists.txt 6824142 
> 
> Diff: http://git.reviewboard.kde.org/r/106970/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20121031/5b40b6cd/attachment.htm>
-------------- next part --------------
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel at kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel